Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diversify Item type classes #392

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Diversify Item type classes #392

merged 1 commit into from
Jun 2, 2023

Conversation

mih
Copy link
Member

@mih mih commented Jun 1, 2023

Originally introduced in
#361, but a need for this has also been expressed elsewhere, hence now a standalone changeset.

These types could also move into datalad_next.types...

Originally introduced in
datalad#361, but a need for this
has also been expressed elsewhere, hence now a standalone changeset.
@mih mih requested a review from christian-monch June 1, 2023 06:10
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 95.28% and project coverage change: +0.02 🎉

Comparison is base (db38176) 92.30% compared to head (ec7614a) 92.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   92.30%   92.33%   +0.02%     
==========================================
  Files         109      109              
  Lines        8262     8280      +18     
==========================================
+ Hits         7626     7645      +19     
+ Misses        636      635       -1     
Impacted Files Coverage Δ
datalad_next/datasets/__init__.py 93.33% <90.90%> (ø)
datalad_next/annexremotes/archivist.py 92.50% <92.50%> (+2.69%) ⬆️
datalad_next/annexremotes/tests/test_archivist.py 98.09% <98.09%> (+0.13%) ⬆️
datalad_next/__init__.py 100.00% <100.00%> (ø)
datalad_next/annexremotes/__init__.py 100.00% <100.00%> (ø)
datalad_next/annexremotes/uncurl.py 94.91% <100.00%> (ø)
datalad_next/iter_collections/utils.py 97.50% <100.00%> (+0.62%) ⬆️
datalad_next/runners/exceptions.py 100.00% <100.00%> (ø)
datalad_next/runners/tests/test_exceptions.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@christian-monch christian-monch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, it makes sense to me (we already discussed the general idea here: #372 (comment)).

As with most categorization efforts, things might change slightly in the future, but I think this is a good trajectory.

datalad_next/iter_collections/utils.py Show resolved Hide resolved
@mih mih merged commit 20b6aea into datalad:main Jun 2, 2023
@mih mih deleted the iteritemtypes branch June 2, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants