Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide pytest-fixture variant of serve_path_via_http #295

Closed
mih opened this issue Mar 7, 2023 · 0 comments · Fixed by #298
Closed

Provide pytest-fixture variant of serve_path_via_http #295

mih opened this issue Mar 7, 2023 · 0 comments · Fixed by #298

Comments

@mih
Copy link
Member

mih commented Mar 7, 2023 •
edited
Loading

This is largely what keeps with_tempfile used in this codebase.

serve_path_via_webdav does not seem to depend on serve_path_via_http from core, hence this could be a first and easier target.
mih added a commit to mih/datalad-next that referenced this issue Mar 7, 2023
@mih
Remove trivial usage of with_tempfile
cb8feaf 
Ping datalad#295
mih added a commit to mih/datalad-next that referenced this issue Mar 7, 2023
@mih
Remove trivial usage of with_tempfile
f9a5cc6 
Ping datalad#295
mih added a commit to mih/datalad-next that referenced this issue Mar 7, 2023
@mih
Fixtures for WebDAV based tests
54a7202 
These replace the old `serve_path_via_webdav` approach. This new
approach is more convenient, and has better test isolation.

Demo follows in next commit.

Ping datalad#295
mih added a commit to mih/datalad-next that referenced this issue Mar 7, 2023
@mih
Use webdav_server fixture for create_sibling_webdav tests
d112d7c 
Ping datalad#295
@mih mih mentioned this issue Mar 7, 2023
Merged
mih added a commit to mih/datalad-next that referenced this issue Mar 7, 2023
@mih
Remove last use of serve_path_via_http
4cf84e1 
Outside its own tests.

Ping datalad#295
mih added a commit to mih/datalad-next that referenced this issue Mar 7, 2023
@mih
Record serve_path_via_webdav deprecation in docstring
fc80206 
Ping datalad#295
mih added a commit to mih/datalad-next that referenced this issue Mar 7, 2023
@mih
serve_path_via_http -> http_server pytest fixture
6aab5da 
This removes the last traces of its usage and simplifies associated
tests.

Closes datalad#295
@mih mih mentioned this issue Mar 7, 2023
Merged
mih added a commit to mih/datalad-next that referenced this issue Mar 7, 2023
@mih
serve_path_via_http -> http_server pytest fixture
a656ac0 
This removes the last traces of its usage and simplifies associated
tests.

Closes datalad#295
@mih mih closed this as completed in #298 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

serve_path_via_http -> http_server pytest fixture mih/datalad-next
1 participant
@mih