include root-dataset and sub-dataset in UUID-set #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-monch
force-pushed
the
bf-update-uuid-set
branch
from
1bee29c to
e04ab05
Compare
This commit fixes a bug in which dataset ids were checked even with un-versioned dataset tree paths
christian-monch
force-pushed
the
bf-update-uuid-set
branch
from
e04ab05 to
e19c476
Compare
Codecov ReportBase: 86.47% // Head: 86.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maint_0.4 #333 +/- ##
=============================================
- Coverage 86.47% 86.31% -0.17%
=============================================
Files 88 88
Lines 4829 4836 +7
=============================================
- Hits 4176 4174 -2
- Misses 653 662 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The newly required version fixes the UUID set issue and some other problems that appeared when adding aggregated metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322
This commit fixes a bug in which sub-dataset entries in the tree-version-list and in the uuid-set would be overriden, if the dataset was a sub-dataset.
The changed code correctly re-uses the top-level nodes that already contain the sub-dataset when adding the super-dataset instead of creating new, empty top-level nodes.