-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a draft of a user guide on writing custom extractors #282
Conversation
Also introduces a "User guide" section to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some more of my doubts / questions, which I didn't include in the text.
Codecov ReportBase: 87.33% // Head: 86.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 87.33% 86.56% -0.78%
==========================================
Files 67 88 +21
Lines 4288 4831 +543
==========================================
+ Hits 3745 4182 +437
- Misses 543 649 +106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Quick comment: I think it would be useful to also include a short description of the |
@mslw Thanks a lot for the description. It is great. I just pushed some updates (more to come), please have a look. |
It felt like I abandoned this PR, so I gave it another read and pushed a few small additions. From my POV, this is pretty much ready. There are two things which I think would improve the article, but I need your help:
I placed these two tings in a todo box at the bottom of the page. Currently don't feel competent to answer these questions, so if you don't want to add them now but like the overall content of this page, I would propose to merge the PR as is, leaving the todo box in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mslw this a great write-up, thanks for doing it! I have nothing to add.
I agree, having the TODOs listed is a good first step, they can be added after this is merged. |
I have linked this PR in an upcoming metalad section in the handbook 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot for the work.
Sorry for taking so long to review it.
Adds more detailed explanations Co-authored-by: Christian Mönch <christian.moench@web.de>
Thanks @christian-monch - I approved all your suggestions and left two minor formatting ones for the changed fragments. |
Done in 1825f8a |
Done in c666447 |
Thanks everyone for the great work. |
This PR introduces a "User guide" section to the docs, and adds a draft of a user guide on writing custom extractors, addressing #281
This is a rather rough draft, based on what I was able to piece together from reading or experimentation, with some statements being just my educated guesses. I also left a couple of TODOs in the text. Since I'll be away for a while, please feel free to hack away on the descriptions. I've allowed edits by maintainers, so you should be able to push changes.
As a side note, I formatted the text with 1 sentence per line (with exceptions) - for me it works well, because then whole sentences can be commented/edited.