-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add web-based metadata entry with HTML/JS and QWebEngineView
#319
base: main
Are you sure you want to change the base?
Conversation
I upgraded Pyside6 from 6.3.1 to 6.3.2, but this had no effect. |
c4f996d
to
f4303f3
Compare
sorry @mslw that was an accidental request |
b0d164d
to
ee1bcbc
Compare
I would want to avoid importing JS assets into the repo. They are more or less just "binary" blobs that we do not intent to maintain. I see two ways:
I'd prefer the latter ATM, but I did not think much about it. |
Although, that would always require internet connectivity when the metadata functionality is used, right? And we specifically want this to be functional while users are not connected? |
(1) Would need it once, yes. (2) would not. The assets are baked into a release as usual. They merely not pollute the repo (just their checksums). |
EDIT: Updating to Pyside 6.4 solved this. Maybe its something on my system, but I can see a metadata browser. Instead, I see two different errors. The first is an uncaught attribute error thrown on the first invocation of
The second seems to be a problem opening the browser, but I suspect its something on my system that might be the problem:
In case someone else has seen this, I'd be curious to get some more insights on how I could make it work. |
This PR aims to add web-based metadata entry with HTML/JS and
QWebEngineView
.