Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataverse extension #110

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Add dataverse extension #110

merged 4 commits into from
Apr 25, 2023

Conversation

yarikoptic
Copy link
Member

attn @mih @bpoldrack @adswa

WDYT?

@yarikoptic
Copy link
Member Author

ok -- it isn't on pypi yet? (even her young brother gooey is there already!)

@adswa
Copy link
Member

adswa commented Oct 25, 2022

So much to do, so little time. I think we'll put it on a lab hackathon agenda.

@adswa
Copy link
Member

adswa commented Mar 17, 2023

Fixed the conflicts and rebased. A release is coming this evening.

extensions.yaml Show resolved Hide resolved
@mih
Copy link
Member

mih commented Mar 18, 2023

Thanks for putting this together. The release was made. It is all green now, but very few tests actually run, because a dataverse token spec is missing. I don't know how to achieve that.

@adswa
Copy link
Member

adswa commented Mar 20, 2023

I can confirm its not enough to set the token as a repository secret

yarikoptic and others added 2 commits April 25, 2023 09:07
Co-authored-by: Michael Hanke <michael.hanke@gmail.com>
@yarikoptic
Copy link
Member Author

cool -- it ran dataverse ones and they passed, let's proceed!

README.md Outdated
[![Documentation](https://readthedocs.org/projects/datalad/badge/?version=latest)](http://datalad.rtfd.org)
[![Extensions](https://github.com/datalad/datalad/actions/workflows/test_extensions.yml/badge.svg)](https://github.com/datalad/datalad/actions/workflows/test_extensions.yml)
[![Linters](https://github.com/datalad/datalad/actions/workflows/lint.yml/badge.svg)](https://github.com/datalad/datalad/actions/workflows/lint.yml)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh -- I think we managed to forget and manually introduce changes to README.md ... I will have to recover from that in this PR

=== Do not change lines below ===
{
 "chain": [
  "064735c5c6a523b311ad8fcaf8ecc7b806458cb9",
  "6e1484ef0f2406880e46f72d034e1cc4de17acfa",
  "a9226eaa2f17838d44814a74f6fa60c6c93f5c49",
  "98e93b6e470a1b97af1a63b051263d1d93701b4e"
 ],
 "cmd": "make generate",
 "dsid": "6b923cfa-a6c6-4bae-941d-e92f6afd5fcb",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [
  "scripts/generate",
  "templates/"
 ],
 "outputs": [
  "README.md",
  ".github/workflows/"
 ],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic merged commit 8d68e91 into master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants