Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [extras] extras_require with datalad-metalad and add all those extras to [devel] #215

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

yarikoptic
Copy link
Member

Development dependencies should be specified in setup.cfg as well, requirements*txt files should only reuse that setup.

Was missed during original PR code review I guess.

@yarikoptic yarikoptic requested a review from asmacdo July 16, 2023 13:14
@codeclimate
Copy link

codeclimate bot commented Jul 16, 2023

Code Climate has analyzed commit ca9aac6 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5bbbf03) 93.95% compared to head (ca9aac6) 93.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          25       25           
  Lines        1091     1091           
=======================================
  Hits         1025     1025           
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic added the internal Changes only affect the internal API label Sep 11, 2023
…tras to [devel]

Development dependencies should be specified in setup.cfg as well,
requirements*txt files should only reuse that setup
@yarikoptic
Copy link
Member Author

rebased, added changelog. if all good -- could be merged

@adswa adswa merged commit a135a00 into datalad:master Sep 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

PR released in 1.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants