Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Singularity 3 from an official .deb, use newer ubuntu (jammy) on travis #188

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

bpoldrack
Copy link
Member

@bpoldrack bpoldrack commented Dec 9, 2022

Doesn't require changelog or release since it's only affecting the CI setup.

@codeclimate
Copy link

codeclimate bot commented Dec 9, 2022

Code Climate has analyzed commit 2ae0526 and detected 0 issues on this pull request.

View more on Code Climate.

.travis.yml Outdated Show resolved Hide resolved
@bpoldrack bpoldrack force-pushed the fix-singularity-install branch from ae0357b to 5abd9f6 Compare December 9, 2022 16:26
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 93.92% // Head: 93.92% // No change to project coverage 👍

Coverage data is based on head (2ae0526) compared to base (2776e72).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          19       19           
  Lines         889      889           
=======================================
  Hits          835      835           
  Misses         54       54           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bpoldrack
Copy link
Member Author

Doesn't work on Travis yet, because there's no singularity release for xenial. Does anyone remember a specific reason to run that old an Ubuntu, @datalad/developers ?

@yarikoptic
Copy link
Member

xenial??? that is nd16.04 , EOLed in April 2021... we can't be using that!... WTF in https://app.travis-ci.com/github/datalad/datalad-container/jobs/590789811 says distribution: debian/stretch/sid and there is no error in installing singularity, only error in finding it or smth like that

 E               FileNotFoundError: [Errno 2] No such file or directory: 'singularity': 'singularity'

? didn't check in further detail

@bpoldrack
Copy link
Member Author

bpoldrack commented Dec 13, 2022

re xenial, @yarikoptic:
See https://app.travis-ci.com/github/datalad/datalad-container/jobs/590789811#L9
According to https://docs.travis-ci.com/user/reference/linux/, xenial is still default on Travis.

That's why the construction of the URL to get the singularity release from, uses xenial (and gets a 404)

And the error with installing singularity is here:
https://app.travis-ci.com/github/datalad/datalad-container/jobs/590789811#L751

@bpoldrack
Copy link
Member Author

Re distribution: debian/stretch/sid reported by datalad wtf:

Could that be neurodebian being at fault here?

@bpoldrack
Copy link
Member Author

When switching to jammy singularity installs fine.

However, now we get a new failure:

$ python setup.py build
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    cmdclass=cmdclass,
  File "/home/travis/virtualenv/python3.7.15/lib/python3.7/site-packages/setuptools/__init__.py", line 144, in setup
    return distutils.core.setup(**attrs)
  File "/opt/python/3.7.15/lib/python3.7/distutils/core.py", line 134, in setup
    ok = dist.parse_command_line()
  File "/opt/python/3.7.15/lib/python3.7/distutils/dist.py", line 483, in parse_command_line
    args = self._parse_command_opts(parser, args)
  File "/home/travis/virtualenv/python3.7.15/lib/python3.7/site-packages/setuptools/dist.py", line 925, in _parse_command_opts
    nargs = _Distribution._parse_command_opts(self, parser, args)
  File "/opt/python/3.7.15/lib/python3.7/distutils/dist.py", line 539, in _parse_command_opts
    cmd_class = self.get_command_class(command)
  File "/home/travis/virtualenv/python3.7.15/lib/python3.7/site-packages/setuptools/dist.py", line 764, in get_command_class
    self.cmdclass[command] = cmdclass = ep.load()
  File "/home/travis/virtualenv/python3.7.15/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2450, in load
    return self.resolve()
  File "/home/travis/virtualenv/python3.7.15/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2456, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
ModuleNotFoundError: No module named 'setuptools.command.build'

That's confusing me, though, since it's supposed to be python 3.7 all along. So, what changed here? Also: Do we even need to run setup.py build?

Seems to be setup/python specific gotcha that it fails to "build" and
IIRC might need freshier setuptools or smth like that
@yarikoptic
Copy link
Member

yeah -- let's try without testing that. pushed

@yarikoptic
Copy link
Member

Could that be neurodebian being at fault here?

not sure how neurodebian could be at fault... if anything it is the python package at fault we are using in datalad wtf to figure out distribution.

@yarikoptic yarikoptic changed the title Install Singularity 3 from official DEB Install Singularity 3 from an official .deb, use newer ubuntu (jammy) on travis Dec 13, 2022
@yarikoptic yarikoptic added tests Add or improve existing tests CHANGELOG-missing labels Dec 13, 2022
@bpoldrack
Copy link
Member Author

Alright, all green, let's go.

@bpoldrack bpoldrack merged commit 5bec343 into datalad:master Dec 13, 2022
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

PR released in 1.1.9

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

PR released in 1.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants