Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenabling tests using SingularityHub #180

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

yarikoptic
Copy link
Member

In effect Reverting 9e488cf
but it was easier to do this way.

Closes #91

Also fixed up one previously skipped test for pytest migration.

In effect Reverting 9e488cf
but it was easier to do this way.

Closes #91

Also fixed up one previously skipped test for pytest  migration.
@codeclimate
Copy link

codeclimate bot commented Aug 30, 2022

Code Climate has analyzed commit cad4019 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #180 (cad4019) into master (120bff7) will increase coverage by 3.96%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   90.00%   93.96%   +3.96%     
==========================================
  Files          19       19              
  Lines         880      878       -2     
==========================================
+ Hits          792      825      +33     
+ Misses         88       53      -35     
Impacted Files Coverage Δ
datalad_container/tests/test_run.py 100.00% <100.00%> (+25.95%) ⬆️
datalad_container/version.py 100.00% <100.00%> (ø)
datalad_container/containers_add.py 91.60% <0.00%> (+0.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yarikoptic yarikoptic added the tests Add or improve existing tests label Aug 30, 2022
@yarikoptic
Copy link
Member Author

good. Adds to coverage. Not sure if worth discussing, thus will proceed

@yarikoptic yarikoptic merged commit 0efcbba into master Aug 30, 2022
@yarikoptic yarikoptic deleted the rf-test-reenable-singhub-tests branch August 30, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable tests when singularity hub is back
1 participant