Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation for docker usage #164

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Clarify documentation for docker usage #164

merged 1 commit into from
Feb 2, 2022

Conversation

mih
Copy link
Member

@mih mih commented Feb 2, 2022

Fixes #159

@mih mih mentioned this pull request Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #164 (b81e7f1) into master (2f6499f) will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   86.29%   85.97%   -0.33%     
==========================================
  Files          17       17              
  Lines         927      927              
==========================================
- Hits          800      797       -3     
- Misses        127      130       +3     
Impacted Files Coverage Δ
datalad_container/containers_add.py 90.90% <ø> (-2.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f6499f...b81e7f1. Read the comment docs.

@mih mih merged commit 80eb592 into datalad:master Feb 2, 2022
@mih mih deleted the doc branch February 2, 2022 08:55
not given.""",
the URL scheme is one recognized by Singularity ('shub://' or
'docker://'), a command format string for Singularity-based
execution will be auto-configrued when
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted this typo: "configrued" => "configured"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @arokem! I will send a PR fix with a few more typo fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document usage with docker
3 participants