Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated Repo.add_submodule() #161

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

mih
Copy link
Member

@mih mih commented Sep 27, 2021

This involves a slight change of the test, which no longer
uses subdataset addressing by submodule name (not path).
A situation that is not achievable via the normal API usage.

Ping datalad/datalad#6010

This involves a slight change of the test, which no longer
uses subdataset addressing by submodule name (not path).
A situation that is not achievable via the normal API usage.
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #161 (d8471fb) into master (c4c5bb2) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   86.37%   86.29%   -0.08%     
==========================================
  Files          17       17              
  Lines         932      927       -5     
==========================================
- Hits          805      800       -5     
  Misses        127      127              
Impacted Files Coverage Δ
datalad_container/tests/test_run.py 77.18% <100.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c5bb2...d8471fb. Read the comment docs.

@mih mih merged commit 1e6ca33 into datalad:master Sep 28, 2021
@mih mih deleted the nosubmoduleadd branch September 28, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant