ENH: Updates functioning of catalog home button #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds improved logic to the function called when user selects the home button:
(this applies when the current location is any tab on any dataset page in a catalog)
- If there is NO home page set:
- if there is a tab name in the URL, navigate to current
- else: don't navigate, only reset
- If there IS a home page set:
- if the current page IS the home page:
- if there is a tab name in the URL, navigate to current
- else: don't navigate, only reset
- if the current page is NOT the home page, navigate to home
(reset = clear filters and set tab index = 0)
|
damn, now what's up with metalad on windows :( https://ci.appveyor.com/project/mih/datalad-catalog/builds/48265221/job/osu78mqs5at52nou |
|
Since the appveyor failure issue is tracked separately in metalad, and it is not influenced by or a prerequisite for code, this PR can be merged |
This should be fixed by release |
|
Thanks @christian-monch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds improved logic to the function called when user selects the home button: (this applies when the current location is any tab on any dataset page in a catalog)
Closes #390