Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: UI/UX #369

Merged
merged 3 commits into from
Oct 1, 2023
Merged

ENH: UI/UX #369

merged 3 commits into from
Oct 1, 2023

Conversation

jsheunis
Copy link
Member

@jsheunis jsheunis commented Oct 1, 2023

This PR:

This replaces the previous behaviour where there was no test for the content of the last updated field
and subsequently an empty value was displayed as an ugly 'NaN', i.e. not good for UX
For items of type file, the cloud icon is removed and the filename is turned into a link
(if the file has an associated URL), and the filesize is updated to display correctly
(empty string and not NaN, if the value is empty). Also, for all items, the cursor will
only turn into a pointer if the item is a folder or a file with a link.
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a75c06b) 86.19% compared to head (498c278) 86.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files          43       43           
  Lines        2709     2709           
=======================================
  Hits         2335     2335           
  Misses        374      374           
Flag Coverage Δ
unittests 79.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants