Compartmentalize the Makefile , exit codes, and associated fixes #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There now is one clean target for each book part, and for each individual usecase
This leads to all dataset IDs being identical
|
I'll merge this now, and hope that the next PR will be less sweeping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Changeset is quite messy - originally I wanted to merely split up the clean targets in the Makefile according to the book structure (2d6be3b). This brought up the need to change the working directories of two sections in the Advanced part (0a69b9a, d85df9d). It also brought to light that identical dataset UUID generation causes problems in the RIA section (77fa11a).
And because the fix in autorunrecord for the latter included a change that created a need to annotate exit codes, this PR also contains exit code annotations for commands that fail on purpose (c633936). It still isn't done (this PR is the code equivalent of a side quest), but I wanted to make the current state transparent.