riastores: Avoid deprecated --no-storage-sibling #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upcoming 0.14 release --no-storage-sibling is deprecated in favor of --storage-sibling=off.
kyleam
force-pushed
the
storage-sibling-off
branch
from
64b39f6
to
fdcffba
Compare
|
Thanks a lot, @kyleam! :) I'll add a note on which version uses which option and merge this in once 0.14 is released. |
kyleam
commented
Jan 27, 2021
| unless :command:`create-sibling-ria` is run with the ``--storage-sibling=off`` | ||
| flag. By default, it has the name of the RIA sibling, suffixed with ``-storage``, | ||
| The storage sibling is the git-annex ora-remote and is set up automatically -- | ||
| unless :command:`create-sibling-ria` is run with ``--storage-sibling=off`` (in DataLad versions ``>0.14.``) or ``no-storage-sibling`` (in versions ``<0.14``). |
There was a problem hiding this comment.
Missing -- in front of no-storage-sibling?
Great, thanks for making my minimal change a proper update. |
…options Thanks to Kyle, this change introduces the successor of --no-storage-sibling and informs about its deprecation. At the moment, both flags remain mentioned, but have a version identifier attached. In the same vein, because it fits, I added a quick note about the storage-sibling=only option recently introduced.
adswa
force-pushed
the
storage-sibling-off
branch
from
a8aadcc
to
6673c2e
Compare
|
Merging - 0.14 release is imminent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming 0.14 release --no-storage-sibling is deprecated in
favor of --storage-sibling=off.
I don't recall where you landed on managing content for different DataLad releases. I'd imagine at the least you'll need to hold off on this a bit, but perhaps the text should be reworked to mention both options for compatibility with earlier releases.