Featurebranch dkw1263 config from db #87
Conversation
…s between github and local
…s between github and local
…s in selftests between github and local
…dot_congig.yml, it's taken from there - if not, it's taken from the db. Also reverted changes in dot_config_github.yml to prevent selftests in GH from failing.
There was a problem hiding this comment.
from the 3 comments that I left, I would only request changes for the 3rd, i.e. dot/config/example/self_tests/dot_config_local.yml should have the config for self_tests, since if you use that file it's because you want to set self tests locally... let me know if it does not make sense for you
for the rest this is a great PR, and I see you leave untouched the yml in the workflow for the github action to trigger self tests for github
thanks!
| @@ -9,12 +9,3 @@ dot_db: | |||
| dbname: dot_db | |||
| schema: dot | |||
| threads: 4 | |||
| ScanProject1_db: | |||
There was a problem hiding this comment.
need to double check, but I this is going to break self tests if you try to run it from docker
personally I don't use the feature, I always run self tests from local and from the execution of PRs in github
so I would agree to remove it, if we know what we are doing, and I would say let's remove it
There was a problem hiding this comment.
Removed as suggested.
| @@ -10,12 +10,3 @@ dot_db: | |||
| dbname: dot_db | |||
| schema: self_tests_dot | |||
| threads: 4 | |||
| ScanProject1_db: | |||
There was a problem hiding this comment.
same as above, I would say let's remove
There was a problem hiding this comment.
Removed as suggested.
| @@ -10,12 +10,3 @@ dot_db: | |||
| dbname: dot_db | |||
| schema: self_tests_dot | |||
| threads: 4 | |||
| ScanProject1_db: | |||
There was a problem hiding this comment.
this one I would not remove, used as a reference if you want to setup self tests locally
…reference for setting up self tests locally.
|
@lrnzcig thank you for the review! As you suggested, I reverted the change in 'dot/config/example/self_tests/dot_config_local.yml' and left 'dot_config_github.yml' and 'dot_config_docker.ym'l without 'ScanProject1'. |
Configuration for projects is now pulled from the DB instead of dot_config.yml file. If the project has not been defined, DOT stops and informs the user immediately instead of after the run. If the project is defined in the dot_config.yml file, the information is NOT taken from the database but from the dot_config.yml file.