Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test type associated columns not null #66

Merged

Conversation

lrnzcig
Copy link
Collaborator

@lrnzcig lrnzcig commented Dec 11, 2022

Fixes #4 for associated_columns_not_null

note that the test was broken - missing e.g. test parameters config, validations, etc

@lrnzcig lrnzcig changed the base branch from main to test_type_expression_is_true December 11, 2022 17:18
@lrnzcig
Copy link
Collaborator Author

lrnzcig commented Dec 11, 2022

@dividor this is the last test type that was missing in the self tests, associated_columns_not_null (issue #4)

I'm pretty sure it was broken, could you please double confirm that we are not using it in Muso?

it is not a extremely useful test, since it is a kind of special case of expression_is_true (where the expression checks for not null of a number of columns), but since it was pretty much implemented and only missing test parameters and validations, and since it is certainly not useless, I've fixed it

any thoughts?

@lrnzcig lrnzcig marked this pull request as ready for review May 2, 2023 18:51
@lrnzcig lrnzcig merged commit f824589 into test_type_expression_is_true May 2, 2023
@lrnzcig lrnzcig deleted the test_type_associated_columns_not_null branch May 2, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The demo data build should include all test types
1 participant