-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move policy/v1beta1 to policy/v1 for K8s 1.25+ compatability #8
feat: Move policy/v1beta1 to policy/v1 for K8s 1.25+ compatability #8
Conversation
@jwitko CI is failing on test. You can run |
So there was some missed That being said, I'm still getting a failure that I am not sure what is going wrong:
I'm not sure what is actually going wrong? Looks like its failing on this test:
|
@jwitko ill take a look. It might be that hash changed, so will need to be updated. Ill get back. Thanks |
ah, any hash of the PDB manifests would have definitely changed. How are the hashes generated and where are they stored? |
@jwitko https://github.com/datainfrahq/druid-operator/blob/master/controllers/druid/testdata/broker-pod-disruption-budget.yaml#L12 |
How are you generating the hash? |
dfb583c
to
918ae6d
Compare
Thanks for the assist @AdheipSingh. Tests should now pass. |
Now the only question remaining... Do we want to add support for the old |
What version of k8s is compatible with v1beta1 ? |
v1.3 - v1.4 : policy/v1alpha1 PodDisruptionBudget introduced |
In that case we can remove, since this is going to be a new release. |
thanks @jwitko |
Fixes #5
Description
This PR moves
policy/v1beta1
topolicy/v1
for the PodDisruptionBudget.policy/v1beta1
was deprecated in K8s 1.21 and removed in 1.25. It should be noted that this PR will make K8s <1.21 unsupported.This PR has:
Key changed/added files in this PR
PodDisruptionBudget