added validations with kubebuilder's markers #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Description
Kubebuilder supports object validation markers. Instead of validating the object inside the reconcile function (in the verifyDruidSpec function, we should let Kubebuilder do it.
For every required field we're adding the // +required marker.
For example, nodeType that now looks like this:
will return:
The Druid "tiny-cluster" is invalid: spec.nodes.brokers.nodeType: Required value
If not specified.The Druid "tiny-cluster" is invalid: spec.nodes.brokers.nodeType: Unsupported value: "brokerr": supported values: "historical", "overlord", "middleManager", "indexer", "broker", "coordinator", "router"
If using unsupported value.This PR has:
Key changed/added files in this PR