Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility to configure PriorityClassName #102

Merged

Conversation

cyril-corbon
Copy link
Collaborator

@cyril-corbon cyril-corbon commented Aug 26, 2023

Fixes ##101

Description

add PriorityClassName to nodeSpec and druidSpec


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • apis/druid/v1alpha1/druid_types.go
  • chart/templates/crds/druid.apache.org_druids.yaml
  • controllers/druid/handler.go

Signed-off-by: Cyril Corbon <corboncyril@gmail.com>
@AdheipSingh
Copy link
Contributor

Thanks @cyril-corbon

@AdheipSingh AdheipSingh merged commit 122be63 into datainfrahq:master Aug 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants