Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese Support #8

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Add Japanese Support #8

merged 1 commit into from
Jan 4, 2022

Conversation

Muennighoff
Copy link
Contributor

@Muennighoff Muennighoff commented Dec 30, 2021 •
edited
Loading

Notes:

  • Additional upgrades could be made, such as more languages & making the downloading of the spaCy models optional / via macros; Given that this plugin isn't used a lot though, I think we can just add JP for now, which has been explicitly requested

Screenshot 2021-12-30 at 12 05 11

@Muennighoff Muennighoff requested a review from du-phan December 30, 2021 11:06
@du-phan
Copy link
Contributor

du-phan commented Jan 4, 2022 •
edited
Loading

LGTM. I did not test it out but the update is minimal so there should be no complications.

@Muennighoff Muennighoff merged commit 6efe98e into master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@du-phan du-phan du-phan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Muennighoff @du-phan