feat(ui): Supporting rendering custom assertion descriptions #9722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2024 12:30
…iptions' into jj--support-assertions-with-descriptions
added 2 commits
January 25, 2024 12:36
…iptions' into jj--support-assertions-with-descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR, I'm adding support for rendering a custom description for any assertion ingested into Datahub. This makes the model much more flexible to accommodate more custom needs.
Simply fill in the "description" field of the AssertionInfo aspect and you'll see it take precedence over our auto-generated description:
Also made sure to support super long descriptions:
Checklist