Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): add ODBC library and tools to base image #9701

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented Jan 24, 2024

Required for SQL Server ingestion.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 24, 2024
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea how much this increases image size? If it's a lot, I'd prefer that we moved this to base-full instead of base-slim

Other than that, this looks reasonable

@darnaut
Copy link
Collaborator Author

darnaut commented Jan 24, 2024

@hsheth2 696 kB according to apt

root@f8f8034b0223:/# apt-get install unixodbc libodbc2
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  libodbcinst2 unixodbc-common
Suggested packages:
  odbc-postgresql tdsodbc
The following NEW packages will be installed:
  libodbc2 libodbcinst2 unixodbc unixodbc-common
0 upgraded, 4 newly installed, 0 to remove and 8 not upgraded.
Need to get 221 kB of archives.
After this operation, 696 kB of additional disk space will be used.
Do you want to continue? [Y/n] 

@hsheth2
Copy link
Collaborator

hsheth2 commented Jan 24, 2024

Not bad at all - seems fine to keep it here

@darnaut darnaut merged commit f627fc4 into master Jan 24, 2024
37 checks passed
@darnaut darnaut deleted the darnaut-docker-datahub-ingestion-base-odbc branch January 24, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants