Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): dynamically get frontend url from gms #8015

Closed
wants to merge 3 commits into from
Closed

feat(sdk): dynamically get frontend url from gms #8015

wants to merge 3 commits into from

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 10, 2023

Also includes ConnectionModel and some improvements to logging.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
feat(sdk): dynamically get frontend url from gms
9863c7a 
Also includes ConnectionModel and some improvements to logging.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 10, 2023
jjoyce0510
jjoyce0510 approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2
Copy link
Collaborator Author

hsheth2 commented May 10, 2023 •
edited
Loading

CI is failing due to the github outage :(

@david-leifker
Copy link
Collaborator

CI doesn't seem like a gha failure here...

@hsheth2
Copy link
Collaborator Author

hsheth2 commented May 22, 2023

@david-leifker yup this is a real failure - will need to work with @jjoyce0510 to figure out how to fix it.

@hsheth2 hsheth2 marked this pull request as draft May 22, 2023 21:14
@shirshanka shirshanka added the on-deck PR or Issue that will be reviewed and/or addressed by the DataHub Maintainers in future cycles label Jun 28, 2024
@hsheth2
Copy link
Collaborator Author

hsheth2 commented Aug 8, 2024

Superseded by #10987

@hsheth2 hsheth2 closed this Aug 8, 2024
hsheth2 added a commit that referenced this pull request Aug 8, 2024
@hsheth2
feat(ingest): various logging improvements
03fbdfe 
Follow up on #8015
@hsheth2 hsheth2 mentioned this pull request Aug 8, 2024
Merged
5 tasks
@hsheth2 hsheth2 deleted the frontend-url-route branch August 10, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata on-deck PR or Issue that will be reviewed and/or addressed by the DataHub Maintainers in future cycles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsheth2 @david-leifker @jjoyce0510 @shirshanka