feat(schema-history): remove blame language for the schema history feature #5457
+329
−184
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| package com.linkedin.datahub.graphql.resolvers.timeline; | ||
|
|
||
| import com.linkedin.common.urn.Urn; | ||
| import com.linkedin.datahub.graphql.generated.GetSchemaVersionListInput; | ||
| import com.linkedin.datahub.graphql.generated.GetSchemaVersionListResult; | ||
| import com.linkedin.datahub.graphql.types.timeline.mappers.SchemaVersionListMapper; | ||
| import com.linkedin.metadata.timeline.TimelineService; | ||
| import com.linkedin.metadata.timeline.data.ChangeCategory; | ||
| import com.linkedin.metadata.timeline.data.ChangeTransaction; | ||
| import graphql.schema.DataFetcher; | ||
| import graphql.schema.DataFetchingEnvironment; | ||
| import java.net.URISyntaxException; | ||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| import static com.linkedin.datahub.graphql.resolvers.ResolverUtils.*; | ||
|
|
||
|
|
||
| /* | ||
| Returns the most recent changes made to each column in a dataset at each dataset version. | ||
| */ | ||
| @Slf4j | ||
| public class GetSchemaVersionListResolver implements DataFetcher<CompletableFuture<GetSchemaVersionListResult>> { | ||
| private final TimelineService _timelineService; | ||
|
|
||
| public GetSchemaVersionListResolver(TimelineService timelineService) { | ||
| _timelineService = timelineService; | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<GetSchemaVersionListResult> get(final DataFetchingEnvironment environment) throws Exception { | ||
| final GetSchemaVersionListInput input = | ||
| bindArgument(environment.getArgument("input"), GetSchemaVersionListInput.class); | ||
|
|
||
| final String datasetUrnString = input.getDatasetUrn(); | ||
| final long startTime = 0; | ||
| final long endTime = 0; | ||
|
|
||
| return CompletableFuture.supplyAsync(() -> { | ||
| try { | ||
| final Set<ChangeCategory> changeCategorySet = new HashSet<>(); | ||
| changeCategorySet.add(ChangeCategory.TECHNICAL_SCHEMA); | ||
| Urn datasetUrn = Urn.createFromString(datasetUrnString); | ||
| List<ChangeTransaction> changeTransactionList = | ||
| _timelineService.getTimeline(datasetUrn, changeCategorySet, startTime, endTime, null, null, false); | ||
| return SchemaVersionListMapper.map(changeTransactionList); | ||
| } catch (URISyntaxException u) { | ||
| log.error( | ||
| String.format("Failed to list schema blame data, likely due to the Urn %s being invalid", datasetUrnString), | ||
| u); | ||
| return null; | ||
|
|
||
| } catch (Exception e) { | ||
| log.error("Failed to list schema blame data", e); | ||
| return null; | ||
|
|
||
| } | ||
| }); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package com.linkedin.datahub.graphql.types.timeline.mappers; | ||
|
|
||
| import com.linkedin.datahub.graphql.generated.GetSchemaVersionListResult; | ||
| import com.linkedin.datahub.graphql.generated.SemanticVersionStruct; | ||
| import com.linkedin.datahub.graphql.types.timeline.utils.TimelineUtils; | ||
| import com.linkedin.metadata.timeline.data.ChangeTransaction; | ||
| import com.linkedin.util.Pair; | ||
| import java.util.Collections; | ||
| import java.util.Comparator; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.stream.Collectors; | ||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| import static com.linkedin.datahub.graphql.types.timeline.utils.TimelineUtils.*; | ||
|
|
||
|
|
||
| // Class for converting ChangeTransactions received from the Timeline API to list of schema versions. | ||
| @Slf4j | ||
| public class SchemaVersionListMapper { | ||
|
|
||
| public static GetSchemaVersionListResult map(List<ChangeTransaction> changeTransactions) { | ||
|
There was a problem hiding this comment. Any chance this list is null? |
||
| if (changeTransactions.isEmpty()) { | ||
| log.debug("Change transactions are empty"); | ||
| return null; | ||
| } | ||
|
|
||
| GetSchemaVersionListResult result = new GetSchemaVersionListResult(); | ||
|
|
||
| String latestSemanticVersionString = | ||
| truncateSemanticVersion(changeTransactions.get(changeTransactions.size() - 1).getSemVer()); | ||
| long latestSemanticVersionTimestamp = changeTransactions.get(changeTransactions.size() - 1).getTimestamp(); | ||
| String latestVersionStamp = changeTransactions.get(changeTransactions.size() - 1).getVersionStamp(); | ||
| result.setLatestVersion( | ||
| new SemanticVersionStruct(latestSemanticVersionString, latestSemanticVersionTimestamp, latestVersionStamp)); | ||
|
|
||
| List<ChangeTransaction> reversedChangeTransactions = changeTransactions.stream() | ||
| .map(TimelineUtils::semanticVersionChangeTransactionPair) | ||
| .filter(Optional::isPresent) | ||
| .map(Optional::get) | ||
| .sorted(Collections.reverseOrder(Comparator.comparing(Pair::getFirst))) | ||
| .map(Pair::getSecond) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| List<SemanticVersionStruct> semanticVersionStructList = reversedChangeTransactions.stream() | ||
| .map(changeTransaction -> new SemanticVersionStruct(truncateSemanticVersion(changeTransaction.getSemVer()), | ||
| changeTransaction.getTimestamp(), changeTransaction.getVersionStamp())) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| result.setSemanticVersionList(semanticVersionStructList); | ||
| return result; | ||
| } | ||
|
|
||
| private SchemaVersionListMapper() { | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - ilike how you hide this detail