Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): preflight - Add way to check/upgrade brew package version in preflight if needed #5435

Merged
merged 2 commits into from
Jul 22, 2022
Merged

feat(ingest): preflight - Add way to check/upgrade brew package version in preflight if needed #5435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf05aae
Add way to check/upgrade brew package version in preflight if needed
treff7es Jul 19, 2022
3928b56
Remove -x from bash script
treff7es Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions metadata-ingestion/scripts/datahub_preflight.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,25 @@
#!/bin/bash -e

#From https://stackoverflow.com/questions/4023830/how-to-compare-two-strings-in-dot-separated-version-format-in-bash
verlte() {
[ "$1" == "$(echo -e "$1\n$2" | sort -V | head -n1)" ]
}

brew_install() {
printf '\n🔎 Checking if %s installed\n' "${1}"
if brew list "$1" &>/dev/null; then
printf '✅ %s is already installed\n' "${1}"
package=${1}
required_version=${2}
printf '\n🔎 Checking if %s installed\n' "${package}"
version=$(brew list --version|grep "$1"|awk '{ print $2 }')

if [ -n "${version}" ]; then
if [ -n "$2" ] && ! verlte "${required_version}" "${version}"; then
printf '🔽 %s is installed but its version %s is lower than the required %s\n' "${package}" "${version}" "${required_version}. Updating version..."
brew update && brew upgrade "$1" && printf '✅ %s is installed\n' "${package}"
else
printf '✅ %s is already installed\n' "${package} with version ${version}"
fi
else
brew install "$1" && printf '✅ %s is installed\n' "${1}"
brew install "$1" && printf '✅ %s is installed\n' "${package}"
fi
}

Expand All @@ -32,7 +46,7 @@ arm64_darwin_preflight() {
fi

printf "✨ Setting up librdkafka prerequisities\n"
brew_install "librdkafka"
brew_install "librdkafka" "1.9.1"
brew_install "openssl@1.1"
brew install "postgresql"

Expand Down