Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/glue): handle error when generating s3 tags for virtual view tables #5398

Merged
merged 2 commits into from
Jul 20, 2022
Merged

fix(ingest/glue): handle error when generating s3 tags for virtual view tables #5398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c585e
fix(ingest/glue): handle error when generating s3 tags for virtual vi…
Jul 18, 2022
17b9ae0
fix lint issues
shirshanka Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions metadata-ingestion/src/datahub/ingestion/source/aws/glue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,6 +1045,10 @@ def get_dataset_properties() -> DatasetPropertiesClass:
)

def get_s3_tags() -> Optional[GlobalTagsClass]:
# when TableType=VIRTUAL_VIEW the Location can be empty and we should
# return no tags rather than fail the entire ingestion
if table.get("StorageDescriptor", {}).get("Location") is None:
return None
bucket_name = s3_util.get_bucket_name(
table["StorageDescriptor"]["Location"]
)
Expand Down