fix(bigquery): missing dependency #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treff7es
approved these changes
Apr 4, 2022
treff7es
reviewed
Apr 4, 2022
metadata-ingestion/setup.py
Outdated
| @@ -150,7 +150,7 @@ def get_long_description(): | |||
| # PyAthena is pinned with exact version because we use private method in PyAthena | |||
| "athena": sql_common | {"PyAthena[SQLAlchemy]==2.4.1"}, | |||
| "azure-ad": set(), | |||
| "bigquery": sql_common | bigquery_common | {"sqlalchemy-bigquery>=1.4.1"}, | |||
| "bigquery": sql_common | bigquery_common | usage_common | {"sqlalchemy-bigquery>=1.4.1"}, | |||
There was a problem hiding this comment.
I think it is a bit misleading we name it as usage_common and we use it with non-usage sources
There was a problem hiding this comment.
Any suggestions?
There was a problem hiding this comment.
maybe add the sqlparser directly?
my concern is that from now on all the additional usage_common dependencies will automatically be a dependency of the bigquery source as well.
Which will be fine if we merge usage with source.
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
* fix(bigquery): missing dependency * code review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3782 introduced a regression due to missing dependencies
#4561 fixed usage sources but missed
bigqueryChecklist