Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Update path generated when creating LookML URL #4554

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

darapuk
Copy link
Contributor

@darapuk darapuk commented Apr 1, 2022

Pathlib by default removes the leading /, which leads to a trailing / being present in file_path after striping repo path.

The trailing / eventually causes the looker url to be incorrect.

I.e.:
base_url//file_path
to
base_url/file_path

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   13m 58s ⏱️ - 11m 36s
686 tests ±0  627 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 9e671b8. ± Comparison against base commit 2fc3a48.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   1h 3m 39s ⏱️ + 2m 3s
   393 tests ±0     393 ✔️ ±0    0 💤 ±0  0 ±0 
1 809 runs  ±0  1 778 ✔️ ±0  31 💤 ±0  0 ±0 

Results for commit 9e671b8. ± Comparison against base commit 2fc3a48.

Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit a05d798 into datahub-project:master Apr 1, 2022
@darapuk darapuk deleted the patch-1 branch April 2, 2022 00:10
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
…t#4554)

* (fix): Update path generated when creating LookML URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants