Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollback) Removes status & key aspects from affected aspects count during rollback #4551

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Mar 31, 2022

Rollback affected entities computation was incorrectly considering key aspects & status aspects as affected entities.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.

@github-actions
Copy link

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   16m 31s ⏱️ -27s
686 tests ±0  627 ✔️ +1  59 💤 ±0  0  - 1 

Results for commit 2d7ec20. ± Comparison against base commit 3fbc84b.

@dexter-mh-lee dexter-mh-lee merged commit 152041b into datahub-project:master Mar 31, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants