Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(assertion): update python example, assertion entity doc #4507

Merged
merged 4 commits into from
Mar 29, 2022
Merged

feat(assertion): update python example, assertion entity doc #4507

merged 4 commits into from
Mar 29, 2022

Conversation

mayurinehate
Copy link
Collaborator

This PR

  • updates python example for emitting assertion info and its results
  • updates document for assertion entity
  • enables lint for metadata-ingestion/examples
  • fixes graphql api to not fail if assertion platform is not set

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

Unit Test Results (build & test)

  93 files    93 suites   24m 29s ⏱️
680 tests 621 ✔️ 59 💤 0 ❌

Results for commit d9e9cdf.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 28, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±  0         5 suites  ±0   59m 34s ⏱️ + 12m 6s
   388 tests +17     388 ✔️ +17    0 💤 ±0  0 ❌ ±0 
1 787 runs  +85  1 756 ✔️ +92  31 💤  - 7  0 ❌ ±0 

Results for commit d9e9cdf. ± Comparison against base commit 6b04dff.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 reviewed Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great to me. A few minor comments. Thank you!

@jjoyce0510 jjoyce0510 merged commit e2723bc into datahub-project:master Mar 29, 2022
@mayurinehate mayurinehate deleted the assertions-examples branch April 6, 2022 08:33
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@mayurinehate @maggiehays
feat(assertion): update python example, assertion entity doc (datahub…
beb3d78 
…-project#4507)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka left review comments

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees

@jjoyce0510 jjoyce0510

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayurinehate @shirshanka @jjoyce0510