Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(metadata-ingestion): callout properties in paragraph #4485

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

andres-lowrie
Copy link
Contributor

@andres-lowrie andres-lowrie commented Mar 24, 2022

It's kinda hard to distinguish these when reading the paragraph; using the backticks makes is obvious that these are properties

It's kinda hard to distinguish these when reading the paragraph; using
the backticks makes is obvious that these are properties
@andres-lowrie andres-lowrie marked this pull request as ready for review March 24, 2022 15:11
@andres-lowrie andres-lowrie changed the title callout properties in paragraph docs(metadata-ingestion): callout properties in paragraph Mar 24, 2022
@maggiehays
Copy link
Collaborator

CC: @pedro93

Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   47m 16s ⏱️ - 1m 48s
   371 tests ±0     371 ✔️ ±0    0 💤 ±0  0 ±0 
1 702 runs  ±0  1 664 ✔️  - 7  38 💤 +7  0 ±0 

Results for commit 470b996. ± Comparison against base commit 611cc2d.

@jjoyce0510 jjoyce0510 merged commit 8564d45 into datahub-project:master Mar 30, 2022
@andres-lowrie andres-lowrie deleted the patch-1 branch March 30, 2022 15:22
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants