Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snowflake): don't recommend accountadmin role for snowflake #4481

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix(snowflake): don't recommend accountadmin role for snowflake #4481

merged 1 commit into from
Mar 24, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   19m 2s ⏱️ + 5m 21s
674 tests ±0  615 ✔️ +1  59 💤 ±0  0 ❌  - 1 

Results for commit 61c3b14. ± Comparison against base commit a1ebc6be.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   48m 27s ⏱️
   371 tests    371 ✔️   0 💤 0 ❌
1 702 runs  1 671 ✔️ 31 💤 0 ❌

Results for commit 61c3b14.

rslanka
rslanka approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit 611cc2d into datahub-project:master Mar 24, 2022
@anshbansal anshbansal deleted the remove-accountadmin-log branch March 24, 2022 14:31
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix(snowflake): don't recommend accountadmin role for snowflake (data…
6808632 
…hub-project#4481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @rslanka