Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tableau): emit lineage edge from embedded datasource to upstream… #4470

Merged
merged 4 commits into from
Mar 30, 2022
Merged

feat(tableau): emit lineage edge from embedded datasource to upstream… #4470

merged 4 commits into from
Mar 30, 2022

Conversation

mayurinehate
Copy link
Collaborator

… published datasource

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 22, 2022 •
edited
Loading

Unit Test Results (build & test)

  96 files  +  4    96 suites  +4   14m 28s ⏱️ + 2m 28s
686 tests +12  627 ✔️ +13  59 💤 ±0  0 ❌  - 1 

Results for commit b9d1344. ± Comparison against base commit 2013d5d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 22, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±    0         5 suites  ±0   59m 30s ⏱️ + 8m 18s
   388 tests +  23     388 ✔️ +  23    0 💤 ±0  0 ❌ ±0 
1 787 runs  +115  1 756 ✔️ +115  31 💤 ±0  0 ❌ ±0 

Results for commit b9d1344. ± Comparison against base commit 2013d5d.

This pull request removes 1 and adds 24 tests. Note that renamed tests count towards both. 
tests.unit.test_kafka_source.KafkaSourceTest ‑ test_get_schema_str_replace_confluent_ref_avro

tests.integration.s3.test_s3 ‑ test_data_lake_incorrect_config_raises_error
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_no_partition.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_no_partition_exclude.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_no_partition_filename.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_no_partition_glob.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_partition_basic.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[folder_partition_keyval.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[multiple_files.json]
tests.integration.s3.test_s3 ‑ test_data_lake_local_ingest[single_file.json]
tests.integration.s3.test_s3 ‑ test_data_lake_s3_ingest[folder_no_partition.json]
…

♻️ This comment has been updated with latest results.

rslanka
rslanka reviewed Mar 23, 2022
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/tableau.py Outdated

for datasource in datasource.get("upstreamDatasources", []):
datasource_urn = builder.make_dataset_urn(
self.platform, datasource.get("id", ""), self.config.env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mayurinehate, should the name param here be datasource["name"] + datasource.get("id", "")? Is the id optional? Also, do we need any updates to the documentation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Only dataset["id"] should be used in urn. It is consistent with other places where we generate urn in order to set lineage correctly.
  2. Id is not optional. updated code for this commit
  3. Added Lineage section in tableau doc to mention lineages emitted

@mayurinehate mayurinehate requested a review from rslanka March 29, 2022 16:07
rslanka
rslanka approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit 9ba3610 into datahub-project:master Mar 30, 2022
@mayurinehate mayurinehate deleted the tableau_embedded_ds_upstream branch April 6, 2022 08:34
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@mayurinehate @rslanka @maggiehays
feat(tableau): emit lineage edge from embedded datasource to upstream… (
7e6d474 
datahub-project#4470)

* feat(tableau): emit lineage edge from embedded datasource to upstream published datasource

Co-authored-by: Ravindra Lanka <rlanka@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees

@rslanka rslanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @rslanka