Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tableau-multiple-upstreamDatabases): fixed wrong database attach to upstream tables #4447

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

cuong-pham
Copy link
Contributor

When there are multiple upstreamDatabases in a datasource, current behaviour is to pick the first database in the list. The fix is to get the database attached directly to upstreamTables.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   12m 44s ⏱️ - 1m 47s
674 tests ±0  615 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 4bcb557. ± Comparison against base commit 2f078c9.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   44m 35s ⏱️ - 6m 57s
   363 tests ±0     363 ✔️ ±0    0 💤 ±0  0 ±0 
1 662 runs  ±0  1 631 ✔️ +7  31 💤  - 7  0 ±0 

Results for commit 4bcb557. ± Comparison against base commit 2f078c9.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

@jjoyce0510 jjoyce0510 merged commit 12bb2e1 into datahub-project:master Mar 18, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants