Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion): snowflake, bigquery - enhancements to log and bugfix #4442

Merged
merged 10 commits into from
Mar 21, 2022
Merged

feat(ingestion): snowflake, bigquery - enhancements to log and bugfix #4442

merged 10 commits into from
Mar 21, 2022

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Mar 17, 2022 •
edited
Loading

  • Problem Scenario fixed for bigquery usage
    • A person starts DataHu quickstart at 02:00 PM 16-Mar-2022 UTC for a POC
    • They go into bigquery and run some sql to create lineage artificially to test things out
    • They run the recipe for bigquery
    • EXPECTED RESULT = They go to DataHub UI expecting to see lineage
    • ACTUAL RESULT = The DataHub UI shows no lineage because Existing code makes end time = 00:15 AM 16-Mar-2022 UTC
    • This scenario would cause people to decide that lineage is broken in bigquery.
  • Problem fixed for snowflake usage
    • If not base objects accessed then we were not getting any usage for snowflake
  • Enhance logging

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@anshbansal anshbansal changed the title Improve log and docs 4 @anshbansal feat(ingestion): add logging for snowflake, bigquery Mar 17, 2022
@anshbansal anshbansal changed the title @anshbansal feat(ingestion): add logging for snowflake, bigquery feat(ingestion): add logging for snowflake, bigquery Mar 17, 2022
@anshbansal anshbansal changed the title feat(ingestion): add logging for snowflake, bigquery feat(ingestion): snowflake, bigquery - enhancements to log and bugfix Mar 17, 2022
@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

Unit Test Results (build & test)

  92 files  +17    92 suites  +17   13m 44s ⏱️ - 7m 27s
674 tests +49  615 ✔️ +50  59 💤 ±0  0 ❌  - 1 

Results for commit 15a48b7. ± Comparison against base commit 2d82531.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files         5 suites   51m 24s ⏱️
   365 tests    365 ✔️   0 💤 0 ❌
1 672 runs  1 641 ✔️ 31 💤 0 ❌

Results for commit 15a48b7.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal closed this Mar 21, 2022
@anshbansal anshbansal reopened this Mar 21, 2022
@anshbansal anshbansal closed this Mar 21, 2022
@anshbansal anshbansal reopened this Mar 21, 2022
rslanka
rslanka approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit c5f1d2c into datahub-project:master Mar 21, 2022
@anshbansal anshbansal deleted the improve-log-and-docs-4 branch March 21, 2022 16:51
@vgaidass vgaidass mentioned this pull request Mar 30, 2022
Closed
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
feat(ingestion): snowflake, bigquery - enhancements to log and bugfix (…
4cca123 
…datahub-project#4442)

feat(ingestion): add logging for snowflake, bigquery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees

@rslanka rslanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @rslanka