Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protobuf) Gradle protobuf example project #4432

Merged
merged 7 commits into from
Mar 17, 2022
Merged

feat(protobuf) Gradle protobuf example project #4432

merged 7 commits into from
Mar 17, 2022

Conversation

leifker
Copy link
Contributor

@leifker leifker commented Mar 16, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   14m 24s ⏱️ - 11m 31s
673 tests ±0  614 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit fb04ff1. ± Comparison against base commit 1ab3ad3.

@leifker leifker force-pushed the leifker/protobuf-gradle-emitter branch from fb04ff1 to 9340291 Compare March 17, 2022 13:18
@leifker leifker changed the title Leifker/protobuf gradle emitter feat(protobuf) Gradle protobuf example project Mar 17, 2022
@leifker leifker force-pushed the leifker/protobuf-gradle-emitter branch 3 times, most recently from f544df9 to 2c0123a Compare March 17, 2022 13:43
@leifker leifker force-pushed the leifker/protobuf-gradle-emitter branch from 2c0123a to 987adde Compare March 17, 2022 13:50
@leifker leifker marked this pull request as ready for review March 17, 2022 14:35
shirshanka
shirshanka approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 628d818 into datahub-project:master Mar 17, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@leifker @maggiehays
feat(protobuf): Gradle protobuf example project (datahub-project#4432)
c75b174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leifker @shirshanka