Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lineage): Move lineage registry to entity-registry module #4412

Merged

Conversation

dexter-mh-lee
Copy link
Contributor

Since it is a layer above the entity registry, and has no direct dependency on any graph libraries, it should be moved to entity-registry module.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   20m 16s ⏱️ + 5m 40s
672 tests ±0  613 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit cbe83a2. ± Comparison against base commit 5535778.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit ab0b516 into datahub-project:master Mar 15, 2022
@dexter-mh-lee dexter-mh-lee deleted the dl--move-lineage-registry branch April 4, 2022 23:47
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants