Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): Fix mypy error stateful committable & restore mypy version. #4408

Merged

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Mar 14, 2022

Fixes the following mypy error and restores the mypy version back.

src/datahub/ingestion/api/committable.py:42: error: Cannot override final attribute "__match_args__" (previously declared in base class "_StatefulCommittableConcrete")
src/datahub/ingestion/api/committable.py:42: error: Cannot override writable attribute "__match_args__" with a final one
src/datahub/ingestion/api/committable.py:42: error: Definition of "__match_args__" in base class "_CommittableConcrete" is incompatible with definition in base class "_StatefulCommittableConcrete"

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@rslanka rslanka changed the title fix(ingestion): Fix mypy error stateful committable fix(ingestion): Fix mypy error stateful committable & restore mypy version. Mar 14, 2022
@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   18m 5s ⏱️ - 2m 1s
672 tests ±0  613 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 8b7d05c. ± Comparison against base commit 1198123.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   48m 55s ⏱️ + 1m 45s
   362 tests ±0     362 ✔️ ±0    0 💤 ±0  0 ±0 
1 657 runs  ±0  1 626 ✔️ ±0  31 💤 ±0  0 ±0 

Results for commit 8b7d05c. ± Comparison against base commit 1198123.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 5aaf187 into datahub-project:master Mar 14, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants