Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): Show recent searches + improved autocomplete #4400

Merged
merged 16 commits into from
Mar 14, 2022

Conversation

jjoyce0510
Copy link
Collaborator

Summary
This PR makes various changes to DataHub's autocomplete.

  1. Show recent searches as autocomplete recs (add Recent Searches recommendation source)
  2. Make entity recommendations clickable, to redirect directly to the entity page.
  3. Show platform logo in the recommendation box.
  4. Native recommendation feeling for Users & Tags.
  5. Fix misc autocomplete related bugs.

Screenshots
Screen Shot 2022-03-13 at 6 57 14 PM
Screen Shot 2022-03-13 at 6 58 25 PM
Screen Shot 2022-03-13 at 6 58 33 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 14, 2022

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   14m 15s ⏱️ + 1m 30s
672 tests ±0  613 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit 0306eee. ± Comparison against base commit cb9b99f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 14, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   44m 24s ⏱️ - 3m 27s
   362 tests ±0     362 ✔️ ±0    0 💤 ±0  0 ±0 
1 657 runs  ±0  1 619 ✔️  - 7  38 💤 +7  0 ±0 

Results for commit 0306eee. ± Comparison against base commit cb9b99f.

♻️ This comment has been updated with latest results.

/**
* Entities that are part of autocomplete by default in Auto Complete Across Entities
*/
public static final List<EntityType> AUTO_COMPLETE_ENTITY_TYPES =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does container and domain not support autocomplete?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it does not :( Adding support can be in a separate PR however

Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! At least the backend side of things

@shirshanka shirshanka merged commit a453ebf into datahub-project:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants