fix(query_combiner): add try block to handle queries of type str #4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code had an early return in case that query did not contain attribute columns. With the new assertion, there is no fallback in the new get_query_columns() function. Hence, some queries fail without a functional fallback. Current work around is to disable the query combiner via: profiling.query_combiner_enabled.
LANCENET
approved these changes
Mar 12, 2022
hsheth2
reviewed
Mar 14, 2022
metadata-ingestion/src/datahub/utilities/sqlalchemy_query_combiner.py
Outdated
Show resolved
Hide resolved
…iner.py Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
hsheth2
approved these changes
Mar 14, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…ahub-project#4397) Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add try block for query_combiner early return in case a query does not contain attributes (inner_columns | columns) as defined by function get_query_columns().
See discussion in #4389
Previous code had an early return in case that query did not contain attribute columns. With the new assertion, there is no fallback in the new get_query_columns() function. Hence, some queries fail without a functional fallback. Current work around is to disable the query combiner via: profiling.query_combiner_enabled.
Checklist