Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion): Add the ability to query the latest timeseries aspect value via the get_cli. #4395

Merged
merged 6 commits into from
Mar 15, 2022

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Mar 12, 2022

Adds support to query the latest timeseries aspect value via the existing get_cli.
No new flags are added. The input/output formats are consistent with the existing non-timeseries aspects.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 12, 2022

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   15m 45s ⏱️ +34s
672 tests ±0  613 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit b1169c7. ± Comparison against base commit af5c4ee.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 12, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   46m 5s ⏱️ - 4m 16s
   362 tests ±0     362 ✔️ ±0    0 💤 ±0  0 ±0 
1 657 runs  ±0  1 626 ✔️ +7  31 💤  - 7  0 ±0 

Results for commit b1169c7. ± Comparison against base commit af5c4ee.

♻️ This comment has been updated with latest results.

@shirshanka
Copy link
Contributor

Maybe add something in the cli documentation for the get command to say that it works for versioned and timeseries aspects both. And for timeseries aspects, it will fetch the latest value?

@rslanka rslanka force-pushed the cli_for_timeseries_aspects branch from 243d24e to b1169c7 Compare March 15, 2022 01:17
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 30ed5f2 into datahub-project:master Mar 15, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants