fix(oidc): Update group membership each login (and make group extraction disabled by default) #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n' into update-group-membership-each-login
…n' into update-group-membership-each-login
shirshanka
approved these changes
Mar 11, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…ion disabled by default) (datahub-project#4380)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the OIDC callback logic to refresh the Groups for a user on each login from SSO. This will completely overwrite the existing groups in datahub when an oidc-managed user logs in, if and only if AUTH_OIDC_EXTRACT_GROUPS_ENABLED environment variable = true. It is set to false by default.
Status
Verified this locally against okta.
Checklist