Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest) bigquery: Fixing missing attribute error if credential was not set #4356

Merged
merged 2 commits into from
Mar 9, 2022
Merged

fix(ingest) bigquery: Fixing missing attribute error if credential was not set #4356

merged 2 commits into from
Mar 9, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Mar 9, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Unit Test Results (build & test)

  76 files  ±0    76 suites  ±0   15m 17s ⏱️ - 7m 37s
629 tests +5  570 ✔️ +6  59 💤 ±0  0 ❌  - 1 

Results for commit ab04e48. ± Comparison against base commit 93acefd.

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   43m 50s ⏱️
   359 tests    359 ✔️   0 💤 0 ❌
1 636 runs  1 605 ✔️ 31 💤 0 ❌

Results for commit ab04e48.

shirshanka
shirshanka approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 799b530 into datahub-project:master Mar 9, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@treff7es @maggiehays
fix(ingest): bigquery - Fixing missing attribute error if credential …
08fc411 
…was not set (datahub-project#4356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka