Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-parsing): add support for variable expansion for in variables in between string #4350

Merged
merged 25 commits into from
Mar 8, 2022
Merged

Conversation

MugdhaHardikar-GSLab
Copy link
Contributor

@MugdhaHardikar-GSLab MugdhaHardikar-GSLab commented Mar 8, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Unit Test Results (metadata ingestion)

       5 files  ±  0         5 suites  ±0   47m 13s ⏱️ + 1m 16s
   355 tests +  2     355 ✔️ +  2    0 💤 ±0  0 ±0 
1 619 runs  +10  1 581 ✔️ +10  38 💤 ±0  0 ±0 

Results for commit 9e8b7f3. ± Comparison against base commit beb51eb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Unit Test Results (build & test)

  76 files  ±0    76 suites  ±0   23m 7s ⏱️ + 6m 52s
624 tests  - 5  564 ✔️  - 6  59 💤 ±0  1 +1 
625 runs   - 4  564 ✔️  - 6  59 💤 ±0  2 +2 

For more details on these failures, see this check.

Results for commit 9e8b7f3. ± Comparison against base commit beb51eb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit f198a92 into datahub-project:master Mar 8, 2022
@MugdhaHardikar-GSLab MugdhaHardikar-GSLab deleted the yml-parsing branch March 30, 2022 05:13
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants