Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest) bigquery: Remove unneeded warning #4317

Merged
merged 1 commit into from
Mar 4, 2022
Merged

fix(ingest) bigquery: Remove unneeded warning #4317

merged 1 commit into from
Mar 4, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Mar 4, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Unit Test Results (build & test)

  71 files  ±0    71 suites  ±0   14m 24s ⏱️ - 2m 21s
618 tests ±0  559 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit f07eb61. ± Comparison against base commit 3158e49.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   44m 47s ⏱️ + 2m 15s
   343 tests ±0     343 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 562 runs  ±0  1 524 ✔️  - 7  38 💤 +7  0 ❌ ±0 

Results for commit f07eb61. ± Comparison against base commit 3158e49.

shirshanka
shirshanka approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit a4c1d5d into datahub-project:master Mar 4, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@treff7es @maggiehays
fix(ingest): bigquery - remove unneeded warning (datahub-project#4317)
3cd640f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka