refactor(ui): Simplify process of adding user.props (w/ docs) #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
reviewed
Mar 2, 2022
docs/how/auth/add-users.md
Outdated
| ## (Advanced) Mount custom user.props file to container | ||
|
|
||
| This step is only required when mounting custom credentials into a Kubernetes pod (e.g. Helm) **or** if you want to change | ||
| the default filesystem location where DataHub checks for a custom `user.props` file (`${HOME}/.datahub/plugins/auth/user.props)`. |
There was a problem hiding this comment.
isn't this /etc/datahub/plugins/auth/user.props (as seen inside the container)
There was a problem hiding this comment.
No - this is if ${HOME}/.datahub/... doesn't work as a source location for you
| @@ -47,7 +52,8 @@ For example, to mount a user.props file that is stored on my local filesystem at | |||
| ..... | |||
| # The new stuff | |||
| volumes: | |||
| - <path-to-your-user.props>:/datahub-frontend/conf/user.props | |||
| - ${HOME}/.datahub/plugins:/etc/datahub/plugins | |||
There was a problem hiding this comment.
have we tested this? where we have /etc/datahub/plugins being mounted and then another directory inside of this directory /etc/datahub/plugins/auth also being mounted
There was a problem hiding this comment.
No - I've not tested this yet. I should though, thanks! The issue with removing the original mounting is that it could have other stuff in it also later down the road
There was a problem hiding this comment.
I did test this. It works!
shirshanka
approved these changes
Mar 4, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify adding users to creating a local user.props at a specific location. When DataHub starts, it will automatically try to mount the custom user.props file to make the process as easy as possible. Also adding docs!
Checklist