Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): Fix snowflake view upstream lineages to eliminate false edges. #4284

Merged

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Mar 1, 2022

The existing query can produce false edges between a view and its upstreams. This fix replaces it with a more robust query against the OBJECT_DEPENDENCIES view (see https://docs.snowflake.com/en/user-guide/object-dependencies.html#object-dependencies).

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Unit Test Results (build & test)

  70 files    70 suites   5m 50s ⏱️
541 tests 489 ✔️ 52 💤 0

Results for commit d3669c0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   41m 4s ⏱️
   343 tests    343 ✔️   0 💤 0
1 562 runs  1 531 ✔️ 31 💤 0

Results for commit d3669c0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit ba0c912 into datahub-project:master Mar 2, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants