Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): Fix snowflake lineage + logging & reporting improvements. #4276

Merged

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Mar 1, 2022

Fixes snowflake lineage (table->table via direct_objects_modified instead of base_objects_modified, inspects all MetadataWorkunits instead of just SqlWorkUnits)
Enhances logging and reporting.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@rslanka rslanka force-pushed the snowflake_ext_lineage_fix branch from 6776244 to 7f91100 Compare March 1, 2022 00:50
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Unit Test Results (build & test)

  71 files  ±0    71 suites  ±0   12m 52s ⏱️ - 7m 46s
618 tests ±0  558 ✔️ ±0  59 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit 7f91100. ± Comparison against base commit 77a2735.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   43m 3s ⏱️ + 1m 46s
   342 tests ±0     342 ✔️ ±0    0 💤 ±0  0 ±0 
1 557 runs  ±0  1 519 ✔️ ±0  38 💤 ±0  0 ±0 

Results for commit 7f91100. ± Comparison against base commit 77a2735.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit f12f653 into datahub-project:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants