Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(schema_version_history): fix semantic version ordering #4271

Merged
merged 4 commits into from
Feb 28, 2022
Merged

bug(schema_version_history): fix semantic version ordering #4271

merged 4 commits into from
Feb 28, 2022

Conversation

RyanHolstien
Copy link
Collaborator

Fixes issues with semantic versioning

  • When multiple categories requested version was per category and looked weird
  • Differs per category did not roll up either
  • No more empty results w/ None semverchange
  • Better colors

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

Unit Test Results (build & test)

  70 files   -   1    70 suites   - 1   6m 37s ⏱️ - 14m 3s
541 tests  - 77  489 ✔️  - 70  52 💤  - 7  0 ❌ ±0 

Results for commit bcbc8f9. ± Comparison against base commit bcabff8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files         5 suites   46m 22s ⏱️
   342 tests    342 ✔️   0 💤 0 ❌
1 557 runs  1 526 ✔️ 31 💤 0 ❌

Results for commit bcbc8f9.

♻️ This comment has been updated with latest results.

rslanka
rslanka approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shirshanka
shirshanka approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 77a2735 into datahub-project:master Feb 28, 2022
@RyanHolstien RyanHolstien deleted the bugfix/semVer branch February 28, 2022 23:14
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@RyanHolstien @maggiehays
fix(platform): timeline - fix semantic version ordering in API respon…
c0e94af 
…se and cli improvements (datahub-project#4271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanHolstien @shirshanka @rslanka